Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug: Non-responsive 'all-plugins' template selection on first try #56

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Fix bug: Non-responsive 'all-plugins' template selection on first try #56

merged 2 commits into from
Aug 17, 2023

Conversation

infacc
Copy link
Contributor

@infacc infacc commented Aug 17, 2023

Fixes #54

@infacc
fix typo
931f9be
@infacc
fix: 'all-plugins' template selection with default template
c7e5e18 
With active default template (set via the `DEFAULT_UI_TEMPLATE` environment variable) selecting the 'all-plugins' template didn't work on the first try.
@infacc infacc requested a review from buehlefs August 17, 2023 11:54
@infacc infacc merged commit 6c549d4 into main Aug 17, 2023
2 checks passed
@infacc infacc deleted the fix/non-responsive-template-selection branch August 17, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buehlefs buehlefs buehlefs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selecting 'all plugins' when a default template is active only works on the second try
2 participants
@infacc @buehlefs